Code Review for jdk-2d

Prepared by:linuxhippy@gmail.com on Thu Feb 22 08:37:26 CET 2018
Workspace:/home/ce/jdk-2d
Compare against: http://hg.openjdk.java.net/jdk/client
Compare against version:48923
Summary of changes: 1546 lines changed: 1303 ins; 193 del; 50 mod; 4759 unchg
Changeset: jdk-2d.changeset
Author comments:
#!/bin/bash # # Copyright (c) 2012, 2014, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it # under the terms of the GNU General Public License version 2 only, as # published by the Free Software Foundation. # # This code is distributed in the hope that it will be useful, but WITHOUT # ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or # FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License # version 2 for more details (a copy is included in the LICENSE file that # accompanied this code). # # You should have received a copy of the GNU General Public License version # 2 along with this work; if not, write to the Free Software Foundation, # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. # # Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA # or visit www.oracle.com if you need additional information or have any # questions. # # This is a thin wrapper which will call the real configure script, and # make sure that is called using bash. # Get an absolute path to this script, since that determines the top-level directory. this_script_dir=`dirname $0` this_script_dir=`cd $this_script_dir > /dev/null && pwd` # Delegate to wrapper, forcing wrapper to believe $0 is this script by using -c. # This trick is needed to get autoconf to co-operate properly. # The ${-:+-$-} construction passes on bash options. bash ${-:+-$-} -c ". $this_script_dir/make/autoconf/configure" $this_script_dir/configure CHECKME $this_script_dir "$@"
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Awt2dLibraries.gmk

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
1 line changed: 0 ins; 0 del; 1 mod; 1100 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/mapfiles/libawt/mapfile-mawt-vers

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48930 : Xrender: Perform Ximg allocation for tile upload only for non-deferred mode
rev 48931 : Xrender: remove mapping leftovers from 8195131
9 lines changed: 9 ins; 0 del; 0 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/mapfiles/libawt_xawt/mapfile-vers

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48930 : Xrender: Perform Ximg allocation for tile upload only for non-deferred mode
rev 48931 : Xrender: remove mapping leftovers from 8195131
10 lines changed: 9 ins; 0 del; 1 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/DirtyRegion.java

rev 48925 : Xrender: Rename MaskTil(eManager) to RectTile(Manager) to avoid confusion later
1 line changed: 0 ins; 0 del; 1 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRBackend.java

rev 48927 : Xrender: make aa tile mask handling a responsibility of the backend implementation
rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
11 lines changed: 4 ins; 2 del; 5 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRBackendNative.java

rev 48927 : Xrender: make aa tile mask handling a responsibility of the backend implementation
rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48930 : Xrender: Perform Ximg allocation for tile upload only for non-deferred mode
41 lines changed: 35 ins; 0 del; 6 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRCompositeManager.java

rev 48925 : Xrender: Rename MaskTil(eManager) to RectTile(Manager) to avoid confusion later
rev 48926 : Xrender: Remove gradient cache, doesn't make sense with current drivers
rev 48927 : Xrender: make aa tile mask handling a responsibility of the backend implementation
rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
67 lines changed: 27 ins; 34 del; 6 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRMaskBlit.java

rev 48927 : Xrender: make aa tile mask handling a responsibility of the backend implementation
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
7 lines changed: 0 ins; 4 del; 3 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRMaskFill.java

rev 48927 : Xrender: make aa tile mask handling a responsibility of the backend implementation
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
5 lines changed: 0 ins; 3 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRRenderer.java

rev 48925 : Xrender: Rename MaskTil(eManager) to RectTile(Manager) to avoid confusion later
2 lines changed: 0 ins; 0 del; 2 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/native/libawt_xawt/java2d/x11/XRBackendNative.c

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48930 : Xrender: Perform Ximg allocation for tile upload only for non-deferred mode
20 lines changed: 6 ins; 8 del; 6 mod; 1098 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/AATileBufMan.java

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48929 : Xrender: move heuristics whether to upload using shm/no-shm PutImage from native to java
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/AATileBuffer.java

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48929 : Xrender: move heuristics whether to upload using shm/no-shm PutImage from native to java
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
168 lines changed: 168 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/RectTile.java (was src/java.desktop/unix/classes/sun/java2d/xr/MaskTile.java)

rev 48925 : Xrender: Rename MaskTil(eManager) to RectTile(Manager) to avoid confusion later
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
3 lines changed: 0 ins; 0 del; 3 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/RectTileManager.java (was src/java.desktop/unix/classes/sun/java2d/xr/MaskTileManager.java)

rev 48925 : Xrender: Rename MaskTil(eManager) to RectTile(Manager) to avoid confusion later
rev 48927 : Xrender: make aa tile mask handling a responsibility of the backend implementation
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
44 lines changed: 0 ins; 30 del; 14 mod; 267 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/unix/classes/sun/java2d/xr/XRBackendDeferred.java

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48929 : Xrender: move heuristics whether to upload using shm/no-shm PutImage from native to java
rev 48932 : XRender: Update+introduce copyright statements + comments + unused import removal
571 lines changed: 571 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/unix/native/libawt_xawt/java2d/x11/XRBackendDeferred.c

rev 48928 : Xrender: Introduction of the deferred backend, allows for accumulated AA mask upload.
rev 48929 : Xrender: move heuristics whether to upload using shm/no-shm PutImage from native to java
288 lines changed: 288 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw configure

0 lines changed: 0 ins; 0 del; 0 mod; 35 unchg

------ ------ ------ ------ Old --- ----- --- src/java.desktop/unix/classes/sun/java2d/xr/XIDGenerator.java

rev 48924 : Xrender: remove unused classes from previous java-only backend
53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/java.desktop/unix/classes/sun/java2d/xr/XcbRequestCounter.java

rev 48924 : Xrender: remove unused classes from previous java-only backend
59 lines changed: 0 ins; 59 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev.ksh (vers 25.16-hg+openjdk.java.net).